xfs
[Top] [All Lists]

Re: [PATCH 1/5] XFS: fix error inversion problems with data flushing

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] XFS: fix error inversion problems with data flushing
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 3 Nov 2008 09:51:33 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081031201830.GA20309@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <1225415729-26514-1-git-send-email-david@xxxxxxxxxxxxx> <1225415729-26514-2-git-send-email-david@xxxxxxxxxxxxx> <20081031201830.GA20309@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Oct 31, 2008 at 04:18:30PM -0400, Christoph Hellwig wrote:
> On Fri, Oct 31, 2008 at 12:15:25PM +1100, Dave Chinner wrote:
> > XFS gets the sign of the error wrong in several places when
> > gathering the error from generic linux functions. These functions
> > return negative error values, while the core XFS code returns
> > positive error values. Hence when XFS inverts the error to be
> > returned to the VFS, it can incorrectly invert a negative
> > error and this error will be ignored by the syscall return.
> > 
> > Fix all the problems related to calling filemap_* functions.
> > 
> > Problem initially identified by Nick Piggin in xfs_fsync().
> 
> But this patch is a little more than just the error code inversions..

Yes, that's the point of the patch - we get it wrong in many
places and this fixes them so that correctly signed error values
are returned to the higher layers....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>