Re: [patch 01/12] Move copy_from_user calls out of ioctl helpers into io

To:	sandeen@xxxxxxxxxxx
Subject:	Re: [patch 01/12] Move copy_from_user calls out of ioctl helpers into ioctl switch.
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 26 Nov 2008 05:03:39 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20081126032026.775790208@sandeen.net>
References:	<20081126032005.639750968@sandeen.net> <20081126032026.775790208@sandeen.net>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Tue, Nov 25, 2008 at 09:20:06PM -0600, sandeen@xxxxxxxxxxx wrote:
> Moving the copy_from_user out of some of the ioctl helpers will
> make it easier for the compat ioctl switch to copy in the right
> struct, then just pass to the underlying helper.
> 
> Also, move common access checks into the helpers themselves,
> and out of the native ioctl switch code, to reduce code
> duplication between native & compat ioctl callers.

Looks good.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [patch 12/12] Reorder xfs_ioctl32.c for some tidiness, (continued) Re: [patch 12/12] Reorder xfs_ioctl32.c for some tidiness, Christoph Hellwig [patch 09/12] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, sandeen Re: [patch 09/12] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, Christoph Hellwig [patch 10/12] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, sandeen Re: [patch 10/12] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, Christoph Hellwig [patch 05/12] Add compat handlers for data & rt growfs ioctls, sandeen Re: [patch 05/12] Add compat handlers for data & rt growfs ioctls, Christoph Hellwig [patch 07/12] Fix xfs_bulkstat_one size checks & error handling, sandeen Re: [patch 07/12] Fix xfs_bulkstat_one size checks & error handling, Christoph Hellwig [patch 01/12] Move copy_from_user calls out of ioctl helpers into ioctl switch., sandeen Re: [patch 01/12] Move copy_from_user calls out of ioctl helpers into ioctl switch., Christoph Hellwig <= [patch 02/12] Move compat ioctl structs & numbers into xfs_ioctl32.h, sandeen Re: [patch 02/12] Move compat ioctl structs & numbers into xfs_ioctl32.h, Christoph Hellwig [patch 03/12] Clean up some existing compat ioctl calls, sandeen Re: [patch 03/12] Clean up some existing compat ioctl calls, Christoph Hellwig Re: [patch 00/12] [PATCH V2]: compat ioctl fixes/cleanups/additions, Eric Sandeen Re: [patch 00/12] [PATCH V2]: compat ioctl fixes/cleanups/additions, Eric Sandeen Re: [patch 00/12] [PATCH V2]: compat ioctl fixes/cleanups/additions, Russell Cattelan

Previous by Date:	Re: Badness in key lookup (length), Martin Steigerwald
Next by Date:	Re: [patch 02/12] Move compat ioctl structs & numbers into xfs_ioctl32.h, Christoph Hellwig
Previous by Thread:	[patch 01/12] Move copy_from_user calls out of ioctl helpers into ioctl switch., sandeen
Next by Thread:	[patch 02/12] Move compat ioctl structs & numbers into xfs_ioctl32.h, sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]