Christoph Hellwig wrote:
> On Tue, Nov 18, 2008 at 10:44:10PM -0600, sandeen@xxxxxxxxxxx wrote:
>> +extern int
>> +xfs_attrmulti_attr_get(struct inode *, char *, char __user *,
>> + __uint32_t *, __uint32_t);
>> +extern int
>> +xfs_attrmulti_attr_set(struct inode *, char *, const char __user *,
>> + __uint32_t, __uint32_t);
>> +extern int
>> +xfs_attrmulti_attr_remove(struct inode *, char *, __uint32_t);
>
> These should be in a header.
ah good point.
>> + if (copy_from_user(&am_hreq, arg,
>> sizeof(compat_xfs_fsop_attrmulti_handlereq_t)))
>> + return -XFS_ERROR(EFAULT);
>> +
>> + error = xfs_vget_fsop_handlereq_compat(mp, parinode, &am_hreq.hreq,
>> &inode);
>
> Far too long lines, please break them up after 80 chars.
>
> Looks good even if the duplication is rather sad..
>
yeah, I don't like it. We could refactor stuff, but I'm also just
trying to get to something that works right now... :)
-Eric
|