Re: [patch 09/11] Hook up compat XFS_IOC_ATTRMULTI_BY

xfs

Re: [patch 09/11] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handl

To:	sandeen@xxxxxxxxxxx
Subject:	Re: [patch 09/11] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 19 Nov 2008 10:16:28 -0500
Cc:	xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
In-reply-to:	<20081119044910.147769242@sandeen.net>
References:	<20081119044401.573365619@sandeen.net> <20081119044910.147769242@sandeen.net>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Tue, Nov 18, 2008 at 10:44:10PM -0600, sandeen@xxxxxxxxxxx wrote:
> +extern int
> +xfs_attrmulti_attr_get(struct inode *, char *, char __user *,
> +                    __uint32_t *, __uint32_t);
> +extern int
> +xfs_attrmulti_attr_set(struct inode *, char *, const char __user *,
> +                   __uint32_t, __uint32_t);
> +extern int
> +xfs_attrmulti_attr_remove(struct inode *, char *, __uint32_t);

These should be in a header.

> +     if (copy_from_user(&am_hreq, arg, 
> sizeof(compat_xfs_fsop_attrmulti_handlereq_t)))
> +             return -XFS_ERROR(EFAULT);
> +
> +     error = xfs_vget_fsop_handlereq_compat(mp, parinode, &am_hreq.hreq, 
> &inode);

Far too long lines, please break them up after 80 chars.

Looks good even if the duplication is rather sad..

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 10/11] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler, (continued) [patch 10/11] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler, sandeen Re: [patch 10/11] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler, Christoph Hellwig [patch 08/11] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, sandeen Re: [patch 08/11] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, Christoph Hellwig [patch 01/11] Move compat ioctl structs & numbers into xfs_ioctl32.h, sandeen Re: [patch 01/11] Move compat ioctl structs & numbers into xfs_ioctl32.h, Christoph Hellwig Re: [patch 01/11] Move compat ioctl structs & numbers into xfs_ioctl32.h, Eric Sandeen Re: [patch 01/11] Move compat ioctl structs & numbers into xfs_ioctl32.h, Eric Sandeen Re: [patch 01/11] Move compat ioctl structs & numbers into xfs_ioctl32.h, Christoph Hellwig [patch 09/11] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, sandeen Re: [patch 09/11] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, Christoph Hellwig <= Re: [patch 09/11] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, Eric Sandeen [patch 04/11] Add compat handlers for swapext ioctl, sandeen Re: [patch 04/11] Add compat handlers for swapext ioctl, Christoph Hellwig [patch 03/11] Add compat handlers for data & rt growfs ioctls, sandeen Re: [patch 03/11] Add compat handlers for data & rt growfs ioctls, Christoph Hellwig Re: [patch 00/11] RFC: compat ioctl fixes/cleanups/additions, Christoph Hellwig

Previous by Date:	Re: [patch 08/11] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler, Christoph Hellwig
Next by Date:	Re: [patch 10/11] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler, Christoph Hellwig
Previous by Thread:	[patch 09/11] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, sandeen
Next by Thread:	Re: [patch 09/11] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]