| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/5] XFS: Avoid using inodes that haven't been completely initialised |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 31 Oct 2008 16:21:29 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1225415729-26514-6-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1225415729-26514-1-git-send-email-david@xxxxxxxxxxxxx> <1225415729-26514-6-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Fri, Oct 31, 2008 at 12:15:29PM +1100, Dave Chinner wrote: > The radix tree walks in xfs_sync_inodes_ag and xfs_qm_dqrele_all_inodes() > can find inodes that are still undergoing initialisation. Avoid > them by checking for the the XFS_INEW() flag once we have a reference > on the inode. This flag is cleared once the inode is properly initialised. Yeah, that's what I meant with my initial comment that we can grab the inodes anytime they are on the radix tree. Looks good. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/5] XFS: fix spurious uninitialised variable warning in xfs_growfs_rt, Christoph Hellwig |
|---|---|
| Next by Date: | Re: do_sync() and XFSQA test 182 failures...., Christoph Hellwig |
| Previous by Thread: | [PATCH 5/5] XFS: Avoid using inodes that haven't been completely initialised, Dave Chinner |
| Next by Thread: | [PATCH 4/5] XFS: fix spurious uninitialised variable warning in xfs_growfs_rt, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |