| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/5] XFS: fix spurious uninitialised variable warning in xfs_growfs_rt |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 31 Oct 2008 16:20:27 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1225415729-26514-5-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1225415729-26514-1-git-send-email-david@xxxxxxxxxxxxx> <1225415729-26514-5-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Fri, Oct 31, 2008 at 12:15:28PM +1100, Dave Chinner wrote: > gcc is warning about an uninitialised variable in xfs_growfs_rt(). > This is a false positive. Fix it by changing the scope of the > transaction pointer to wholly within the internal loop inside > the function. > > While there, preemptively change xfs_growfs_rt_alloc() in the > same way as it has exactly the same structure as xfs_growfs_rt() > but gcc is not warning about it. Yet. Looks good. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/5] XFS: fix uninitialised variable bug in dquot release., Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 5/5] XFS: Avoid using inodes that haven't been completely initialised, Christoph Hellwig |
| Previous by Thread: | [PATCH 4/5] XFS: fix spurious uninitialised variable warning in xfs_growfs_rt, Dave Chinner |
| Next by Thread: | [PATCH 1/5] XFS: fix error inversion problems with data flushing, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |