xfs
[Top] [All Lists]

Re: [PATCH 1/5] XFS: fix error inversion problems with data flushing

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] XFS: fix error inversion problems with data flushing
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 31 Oct 2008 16:18:30 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1225415729-26514-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1225415729-26514-1-git-send-email-david@xxxxxxxxxxxxx> <1225415729-26514-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Oct 31, 2008 at 12:15:25PM +1100, Dave Chinner wrote:
> XFS gets the sign of the error wrong in several places when
> gathering the error from generic linux functions. These functions
> return negative error values, while the core XFS code returns
> positive error values. Hence when XFS inverts the error to be
> returned to the VFS, it can incorrectly invert a negative
> error and this error will be ignored by the syscall return.
> 
> Fix all the problems related to calling filemap_* functions.
> 
> Problem initially identified by Nick Piggin in xfs_fsync().

But this patch is a little more than just the error code inversions..

<Prev in Thread] Current Thread [Next in Thread>