[Top] [All Lists]

Re: [PATCH 1/2] wire up ->open for directories

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 1/2] wire up ->open for directories
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 27 Oct 2008 12:20:08 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081026203437.GB4173@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
References: <20081026203437.GB4173@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Oct 26, 2008 at 04:34:37PM -0400, Christoph Hellwig wrote:
> Currently there's no ->open method set for directories on XFS.  That
> means we don't perform any check for opening too large directories
> without O_LARGEFILE, we don't check for shut down filesystems, and we
> don't actually do the readahead for the first block in the directory.
> Instead of just setting the directories open routine to xfs_file_open
> we merge the shutdown check directly into xfs_file_open and create
> a new xfs_dir_open that first calls xfs_file_open and then performs
> the readahead for block 0.

Looks good to me.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>