Fix a few problematic open calls which strict checking catches;
in most cases just missing a mode with O_CREAT.
Removed the #ifdef CRAY instance around one, per hch's request.
Somebody else can remove the rest, when motivated.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
---
Index: xfstests/ltp/iogen.c
===================================================================
--- xfstests.orig/ltp/iogen.c
+++ xfstests/ltp/iogen.c
@@ -1060,7 +1060,7 @@ int nbytes;
Oflags |= O_CREAT | O_WRONLY;
- if ((fd = open(path, Oflags, 0666, Ocbits, Ocblks)) == -1) {
+ if ((fd = open(path, Oflags, 0666)) == -1) {
fprintf(stderr, "iogen%s: Could not create/open file %s: %s (%d)\n",
TagName, path, SYSERR, errno);
return -1;
Index: xfstests/src/multi_open_unlink.c
===================================================================
--- xfstests.orig/src/multi_open_unlink.c
+++ xfstests/src/multi_open_unlink.c
@@ -92,7 +92,7 @@ main(int argc, char *argv[])
return 1;
}
- fd = open(path, O_RDWR|O_CREAT|O_EXCL);
+ fd = open(path, O_RDWR|O_CREAT|O_EXCL, 0666);
if (fd == -1) {
fprintf(stderr, "%s: failed to create \"%s\": %s\n",
prog, path, strerror(errno));
return 1;
Index: xfstests/src/enospc_unlink.c
===================================================================
--- xfstests.orig/src/enospc_unlink.c
+++ xfstests/src/enospc_unlink.c
@@ -40,7 +40,7 @@ int main(int argc, char **argv)
memset(ptr, 0xffffffff, sz);
for (i = 0; i < count; i++) {
- fd = open(argv[1], O_CREAT|O_WRONLY);
+ fd = open(argv[1], O_CREAT|O_WRONLY, 0666);
if (fd < 0) {
perror(argv[1]);
exit(1);
Index: xfstests/src/dmiperf.c
===================================================================
--- xfstests.orig/src/dmiperf.c
+++ xfstests/src/dmiperf.c
@@ -203,7 +203,7 @@ mkfile(char *name, char *attr)
ssize_t wrote, wsize;
off64_t bytes = fsize;
- if ((fd = open(name, O_WRONLY | O_CREAT | O_EXCL | O_DIRECT)) < 0) {
+ if ((fd = open(name, O_WRONLY | O_CREAT | O_EXCL | O_DIRECT, 0666)) <
0) {
perror("open");
exit(1);
}
|