xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix nr of args in open calls

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix nr of args in open calls
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 25 Oct 2008 16:22:32 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <49037F3C.6030007@xxxxxxxxxxx>
References: <49036961.8070100@xxxxxxxxxxx> <20081025201715.GA28002@xxxxxxxxxxxxx> <49037F3C.6030007@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Oct 25, 2008 at 03:19:08PM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > On Sat, Oct 25, 2008 at 01:45:53PM -0500, Eric Sandeen wrote:
> >> --- xfstests.orig/ltp/iogen.c
> >> +++ xfstests/ltp/iogen.c
> >> @@ -1060,7 +1060,11 @@ int         nbytes;
> >>  
> >>      Oflags |= O_CREAT | O_WRONLY;
> >>  
> >> +#ifdef CRAY
> >>      if ((fd = open(path, Oflags, 0666, Ocbits, Ocblks)) == -1) {
> >> +#else
> >> +    if ((fd = open(path, Oflags, 0666)) == -1) {
> >> +#endif
> > 
> > Do we really need that ifdef cray here?
> 
> Not sure; Ocbits etc are set under the same #ifdef, xfsqa runs on irix,
> and I'm not sure what all gets set on that build ...

#ifdef CRAY is for Unicos, and I don't think xfsqa near it's current
version can run there.  I'd rather see all this striped out, but at
least no new occurances added.

<Prev in Thread] Current Thread [Next in Thread>