xfs
[Top] [All Lists]

Re: [PATCH] clean up printk formats with DMAPI_DEBUG

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] clean up printk formats with DMAPI_DEBUG
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 25 Oct 2008 16:20:05 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <49031BB1.7080609@xxxxxxxxxxx>
References: <49031BB1.7080609@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Oct 25, 2008 at 08:14:25AM -0500, Eric Sandeen wrote:
>  #ifdef CONFIG_DMAPI_DEBUG
> -     printk("xfs_dm_round_hole: off %lu, len %ld, align %lu, "
> -            "filesize %llu, roff %ld, rlen %ld\n",
> +     printk("xfs_dm_round_hole: off %lld, len %llu, align %llu, "
> +            "filesize %lld, roff %lld, rlen %llu\n",
>              offset, length, align, filesize, *roff, *rlen);

We'd still need casts to (unsigned) long long because the 64 bit
types may be either variant on 64 bit platforms.

<Prev in Thread] Current Thread [Next in Thread>