xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix nr of args in open calls

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix nr of args in open calls
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 25 Oct 2008 15:19:08 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20081025201715.GA28002@xxxxxxxxxxxxx>
References: <49036961.8070100@xxxxxxxxxxx> <20081025201715.GA28002@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
Christoph Hellwig wrote:
> On Sat, Oct 25, 2008 at 01:45:53PM -0500, Eric Sandeen wrote:
>> --- xfstests.orig/ltp/iogen.c
>> +++ xfstests/ltp/iogen.c
>> @@ -1060,7 +1060,11 @@ int   nbytes;
>>  
>>      Oflags |= O_CREAT | O_WRONLY;
>>  
>> +#ifdef CRAY
>>      if ((fd = open(path, Oflags, 0666, Ocbits, Ocblks)) == -1) {
>> +#else
>> +    if ((fd = open(path, Oflags, 0666)) == -1) {
>> +#endif
> 
> Do we really need that ifdef cray here?

Not sure; Ocbits etc are set under the same #ifdef, xfsqa runs on irix,
and I'm not sure what all gets set on that build ...

-Eric

<Prev in Thread] Current Thread [Next in Thread>