xfs
[Top] [All Lists]

Re: [PATCH 1/2] convert xfs_getbmap to take formatter functions

To: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH 1/2] convert xfs_getbmap to take formatter functions
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 23 Oct 2008 19:44:08 -0500
In-reply-to: <20081023233538.GG18495@disturbed>
References: <490103C9.9080900@xxxxxxxxxxx> <20081023233538.GG18495@disturbed>
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
Dave Chinner wrote:
> On Thu, Oct 23, 2008 at 06:07:53PM -0500, Eric Sandeen wrote:
>> Preliminary work to hook up fiemap, this allows us to pass in an
>> arbitrary formatter to copy extent data back to userspace.
> 
> Is there a fiemap test program around anywhere?
> 
> If so, would it be appropriate to include it in xfstests and write
> a quick regression test for it? We'd probably need to also check
> xfs_bmap gives the same output as fiemap....

I have a very hacky app/test that can exercise the interface; there is
nothing, as far as I know, that will create "every" possible combination
of output and test for correct output ... but yes, this interface should
get at least something in the test suite.

-Eric

> Cheers,
> 
> Dave.

<Prev in Thread] Current Thread [Next in Thread>