Eric Sandeen wrote:
> KELEMEN Peter wrote:
>> Eric has pointed out that verify_set_primary_sb() will either
>> return 1 or XR_INSUFF_SEC_SB. Move the check lower into
>> verify_set_primary_sb() by checking the return value of
>> verify_sb(). Example output:
>>
>> found candidate secondary superblock...
>> verifying sb at 31249334272: bad magic number (1)
>> verifying sb at 62498668544: bad magic number (1)
>> verifying sb at 93748002816: bad magic number (1)
>> verifying sb at 124997337088: bad magic number (1)
>> unable to verify superblock, continuing...
>>
>
> This looks better :) You may want to add even more info...
>
> while it's just searching block by block, if it finds a candidate, I'd
> print the sector offset for that candidate (your first output line).
>
> And rather than "verifying sb at..." you might do something like
> "comparing to sb N at offset X":
>
> + } else {
> + do_warn("comparing with sb %d at sector %Lu failed: %s (%d)\n",
> + agno, off, err_string(reason), reason);
Sorry, that was a pre-coffee email :) The units are bytes, not sectors,
aren't they... in any case, printing the (proper) units for the values
would be helpful.
-Eric
|