xfs
[Top] [All Lists]

TAKE 987246 - stop using xfs_itobp in xfs_bulkstat

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: TAKE 987246 - stop using xfs_itobp in xfs_bulkstat
From: lachlan@xxxxxxx (Lachlan McIlroy)
Date: Thu, 23 Oct 2008 17:51:49 +1100 (EST)
stop using xfs_itobp in xfs_bulkstat

xfs_bulkstat only wants the dinode, offset and buffer from a given
inode number.  Instead of using xfs_itobp on a fake inode which is
complicated and currently leads to leaks of the security data just use
xfs_inotobp which is designed to do exactly the kind of lookup
xfs_bulkstat wants.  The only thing that's missing in xfs_inotobp is
a flags paramter that let's us pass down XFS_IMAP_BULKSTAT, but that can
easily added.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Date:  Thu Oct 23 17:51:16 EST 2008
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-hch
Inspected by:  david@xxxxxxxxxxxxx
Author:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:32397a
fs/xfs/xfs_itable.c - 1.173 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_itable.c.diff?r1=text&tr1=1.173&r2=text&tr2=1.172&f=h
fs/xfs/xfs_inode.c - 1.535 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.c.diff?r1=text&tr1=1.535&r2=text&tr2=1.534&f=h
fs/xfs/xfs_inode.h - 1.266 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.h.diff?r1=text&tr1=1.266&r2=text&tr2=1.265&f=h
        - stop using xfs_itobp in xfs_bulkstat



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 987246 - stop using xfs_itobp in xfs_bulkstat, Lachlan McIlroy <=