[Top] [All Lists]

TAKE 987246 - fs/xfs/linux-2.6/xfs_sync.c

To: xfs@xxxxxxxxxxx, sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 987246 - fs/xfs/linux-2.6/xfs_sync.c
From: pleckie@xxxxxxx (Peter Leckie)
Date: Thu, 23 Oct 2008 17:07:16 +1100 (EST)
avoid all reclaimable inodes in xfs_sync_inodes_ag

If we are syncing data in xfs_sync_inodes_ag(), the VFS
inode must still be referencable as the dirty data state
is carried on the VFS inode. hence if we can't get a
reference via igrab(), the inode must be in reclaim which
implies that it has no dirty data attached.

Leave such inodes to the reclaim code to flush the dirty
inode state to disk and so avoid attempting to access the
VFS inode when it may not exist in xfs_sync_inodes_ag().

Version 4:
o don't reference liinux inode untiil after igrab() succeeds

Version 3:
o converted unlock/rele to an xfs_iput() call.

Version 2:
o change igrab logic to be more linear
o remove initial reclaimable inode check now that we are using
  igrab() failure to find reclaimable inodes
o assert that igrab failure occurs only on reclaimable inodes
o clean up inode locking - only grab the iolock if we are doing
  a SYNC_DELWRI call and we have a dirty inode.

Date:  Thu Oct 23 17:06:31 EST 2008
Workarea:  chapter11.melbourne.sgi.com:/scratch/pleckie/2.6.x-xfs
Inspected by:  pleckie,david@xxxxxxxxxxxxx,hch@xxxxxxxxxxxxx

The following file(s) were checked into:

Modid:  xfs-linux-melb:xfs-kern:32391a
fs/xfs/linux-2.6/xfs_sync.c - 1.24 - changed
        - avoid all reclaimable inodes in xfs_sync_inodes_ag

<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 987246 - fs/xfs/linux-2.6/xfs_sync.c, Peter Leckie <=