xfs
[Top] [All Lists]

Re: BUG: sleeping function called from invalid context at kernel/rwsem.c

To: "Dave Chinner" <david@xxxxxxxxxxxxx>, lachlan@xxxxxxx, "Christoph Hellwig" <hch@xxxxxxxxxxxxx>, "Arjan van de Ven" <arjan@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>
Subject: Re: BUG: sleeping function called from invalid context at kernel/rwsem.c:131 XFS? (was: Re: linux-next: Tree for October 17)
From: "Alexander Beregalov" <a.beregalov@xxxxxxxxx>
Date: Wed, 22 Oct 2008 13:12:22 +0400
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=DbVjh/cHu7ZemzCg0hbJ1K82Ddf087kZbAQsRVL5tc4=; b=nXXSXte9c+GMRpOIwTMT6RMcvto3UgeTNRE1gyah+dpn+ucT6/AzniN3TK0biAMPAa HHCPwsbgaFPrFObxj/0z/J6iwgZyd+Msap5IvsTmArhlZaYcRnsViUQpIJ3pAnUWcwo1 /PBiqyEMFESDKSxhO9abvvzHh2n3lgIeQ0dmg=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=lcGGHkXc+zYH/telubf3FmlYORJEXNslgtfcalerOLiVt2lD5+F9qBUJgXJ7g9tOLZ xFurc6F3AbbUh/gNR1+SPKbl+ouM2fi5VUNAkTkDuNjztHpRibLrJQVucoqF7379ZFud N5rgJU9jZtsBmq0b3+LjrwT3uOqAzQHP2tMc8=
In-reply-to: <20081022082550.GM18495@disturbed>
References: <20081017165738.GA20818@xxxxxxxxxxxxx> <20081017203710.GA27187@xxxxxxxxxxxxx> <20081017135510.7127c4e7@xxxxxxxxxxxxx> <a4423d670810200758m3cea3841h40988afc8eaf81@xxxxxxxxxxxxxx> <20081020163327.GA15651@xxxxxxxxxxxxx> <a4423d670810201013w6448cb38w402771799cefb5f5@xxxxxxxxxxxxxx> <20081020223549.GA21152@disturbed> <a4423d670810210442y51b62fc2naf6cb649e6b26942@xxxxxxxxxxxxxx> <20081022075838.GK18495@disturbed> <20081022082550.GM18495@disturbed>
2008/10/22 Dave Chinner <david@xxxxxxxxxxxxx>:
> On Wed, Oct 22, 2008 at 06:58:38PM +1100, Dave Chinner wrote:
>> On Tue, Oct 21, 2008 at 03:42:16PM +0400, Alexander Beregalov wrote:
>> > Bisected to:
>> > dd509097cb0b76d3836385f80d6b2d6fd3b97757 is first bad commit
>> > commit dd509097cb0b76d3836385f80d6b2d6fd3b97757
>> > Author: Lachlan McIlroy <lachlan@xxxxxxx>
>> > Date:   Mon Sep 29 14:56:40 2008 +1000
>> >
>> >     [XFS] Unlock inode before calling xfs_idestroy()
>> >
>> >     Lock debugging reported the ilock was being destroyed without being
>> >     unlocked. We don't need to lock the inode until we are going to insert 
>> > it
>> >     into the radix tree.
>>
>> Ah, OK, I see the problem, though I don't understand why I'm not
>> seeing the might_sleep() triggering all the time given that I always
>> build with:
>>
>> $ grep SLEEP .config
>> CONFIG_DEBUG_SPINLOCK_SLEEP=y
>>
>> Basically the above commit moved xfs_ilock() inside
>> radix_tree_preload()/radix_tree_preload_end(), which means we are
>> taking a rwsem() while we have an elevated preempt count. I'll
>> get a patch out to fix it.
>
> Patch below (against the xfs master/linux-next branch) should fix the
> regression. I've just started QA on it. Can you please check that
> it works for you, Alexander?
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@xxxxxxxxxxxxx
>
> XFS: Can't lock inodes in radix tree preload region
>
> When we are inside a radix tree preload region, we cannot
> sleep. Recently we moved the inode locking inside the
> preload region for the inode radix tree. Fix that,
> and fix a missed unlock in another error path in the
> same code at the same time.
>
> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
Tested-by: Alexander Beregalov <a.beregalov@xxxxxxxxx>

Yes, it fixes the issue. Thanks

<Prev in Thread] Current Thread [Next in Thread>