xfs
[Top] [All Lists]

Re: BUG: sleeping function called from invalid context at kernel/rwsem.c

To: Alexander Beregalov <a.beregalov@xxxxxxxxx>
Subject: Re: BUG: sleeping function called from invalid context at kernel/rwsem.c:131 XFS? (was: Re: linux-next: Tree for October 17)
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 22 Oct 2008 19:28:29 +1100
Cc: lachlan@xxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Arjan van de Ven <arjan@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <a4423d670810220121k27ab3d1dp1921ea282786eebc@xxxxxxxxxxxxxx>
Mail-followup-to: Alexander Beregalov <a.beregalov@xxxxxxxxx>, lachlan@xxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Arjan van de Ven <arjan@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>
References: <a4423d670810171013g5bc19c1cm3f7d9c014ee70349@xxxxxxxxxxxxxx> <20081017203710.GA27187@xxxxxxxxxxxxx> <20081017135510.7127c4e7@xxxxxxxxxxxxx> <a4423d670810200758m3cea3841h40988afc8eaf81@xxxxxxxxxxxxxx> <20081020163327.GA15651@xxxxxxxxxxxxx> <a4423d670810201013w6448cb38w402771799cefb5f5@xxxxxxxxxxxxxx> <20081020223549.GA21152@disturbed> <a4423d670810210442y51b62fc2naf6cb649e6b26942@xxxxxxxxxxxxxx> <20081022075838.GK18495@disturbed> <a4423d670810220121k27ab3d1dp1921ea282786eebc@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Oct 22, 2008 at 12:21:23PM +0400, Alexander Beregalov wrote:
> > Ah, OK, I see the problem, though I don't understand why I'm not
> > seeing the might_sleep() triggering all the time given that I always
> > build with:
> >
> > $ grep SLEEP .config
> > CONFIG_DEBUG_SPINLOCK_SLEEP=y
> >
> > Basically the above commit moved xfs_ilock() inside
> > radix_tree_preload()/radix_tree_preload_end(), which means we are
> > taking a rwsem() while we have an elevated preempt count. I'll
> > get a patch out to fix it.
> Could it cause the I/O dead lock or should I continue trying to reproduce it?

The deadlock wouldn't be produced by the same thing that
produced the sleeping-in-atomic warning. The missed unlock that
I also fixed in the patch I just sent could possibly have caused
that, but I'm just speculating on that...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>