| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/3] stop using xfs_itobp in xfs_bulkstat |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 22 Oct 2008 07:36:13 +1100 |
| Cc: | Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20081021081329.GA23344@xxxxxxxxxxxxx> |
| Mail-followup-to: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx |
| References: | <20081020222036.GA23662@xxxxxx> <20081021024455.GB18495@disturbed> <20081021081329.GA23344@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Tue, Oct 21, 2008 at 04:13:29AM -0400, Christoph Hellwig wrote: > On Tue, Oct 21, 2008 at 01:44:55PM +1100, Dave Chinner wrote: > > On Tue, Oct 21, 2008 at 12:20:36AM +0200, Christoph Hellwig wrote: > > > xfs_bulkstat only wants the dinode, offset and buffer from a given > > > inode number. Instead of using xfs_itobp on a fake inode that is much > > > easier done with xfs_inotobp, which just needs an imap_flag paramter to > > > pass down the XFS_IMAP_BULKSTAT flag. > > > > Nice - that removes the only external user of xfs_inode_alloc() very > > cleanly. Looks ok to me. > > Which means we should mark it static now. Updated patch below: Looks good. BTW, the original patch series has run through xfsqa on my setup overnight without any problems. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Partition seems to have been zero:ed. For no reason., Johan Stenehall |
|---|---|
| Next by Date: | Re: [PATCH 3/3] free inodes using destroy_inode, Dave Chinner |
| Previous by Thread: | Re: [PATCH 1/3] stop using xfs_itobp in xfs_bulkstat, Christoph Hellwig |
| Next by Thread: | [PATCH 2/3] stop using xfs_itobp in xfs_iread, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |