xfs
[Top] [All Lists]

Re: [PATCH 1/2, RFC] convert xfs_getbmap to take formatter functions

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/2, RFC] convert xfs_getbmap to take formatter functions
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 21 Oct 2008 09:31:04 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <48FDD7AA.5050006@xxxxxxxxxxx>
References: <48FD0503.3090203@xxxxxxxxxxx> <20081021080737.GA4193@xxxxxxxxxxxxx> <48FDD7AA.5050006@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Oct 21, 2008 at 08:22:50AM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > On Mon, Oct 20, 2008 at 05:24:03PM -0500, Eric Sandeen wrote:
> ...
> 
> >>  /*
> >> - * Fcntl interface to xfs_bmapi.
> >> + * ioctl interface to xfs_bmapi.
> >>   */
> > 
> >>  /*
> >> - * Fcntl interface to xfs_bmapi.
> >> + * ioctl interface to xfs_bmapi.
> >>   */
> > 
> > Well, it will be for fiemap, too.  And the comment doesn't make much
> > sense either.  Either remove it completely or replace it by something
> > that makes sense.
> > 
> 
> well aren't XFS_IOC_GETBMAP(X) and fiemap _both_ ioctl interfaces to
> xfs_bmapi?

Hmm, From the syscall point of view fiemap is indeed an ioctl, too.
But then again the point of this function isn't do anything
ioctl-related, but to allow to get a list of all extents for an inode
and format them arbitrarily.

<Prev in Thread] Current Thread [Next in Thread>