xfs
[Top] [All Lists]

Re: [PATCH 1/2, RFC] convert xfs_getbmap to take formatter functions

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2, RFC] convert xfs_getbmap to take formatter functions
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 21 Oct 2008 08:22:50 -0500
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20081021080737.GA4193@xxxxxxxxxxxxx>
References: <48FD0503.3090203@xxxxxxxxxxx> <20081021080737.GA4193@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
Christoph Hellwig wrote:
> On Mon, Oct 20, 2008 at 05:24:03PM -0500, Eric Sandeen wrote:
...

>>  /*
>> - * Fcntl interface to xfs_bmapi.
>> + * ioctl interface to xfs_bmapi.
>>   */
> 
>>  /*
>> - * Fcntl interface to xfs_bmapi.
>> + * ioctl interface to xfs_bmapi.
>>   */
> 
> Well, it will be for fiemap, too.  And the comment doesn't make much
> sense either.  Either remove it completely or replace it by something
> that makes sense.
> 

well aren't XFS_IOC_GETBMAP(X) and fiemap _both_ ioctl interfaces to
xfs_bmapi?

-Eric

<Prev in Thread] Current Thread [Next in Thread>