xfs
[Top] [All Lists]

Re: [PATCH 1/2, RFC] convert xfs_getbmap to take formatter functions

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/2, RFC] convert xfs_getbmap to take formatter functions
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 21 Oct 2008 04:07:37 -0400
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <48FD0503.3090203@xxxxxxxxxxx>
References: <48FD0503.3090203@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Oct 20, 2008 at 05:24:03PM -0500, Eric Sandeen wrote:
> Preliminary work to hook up fiemap, this allows us to pass in an
> arbitrary formatter to copy extent data back to userspace.
> 
> The formatter takes info for 1 extent, a pointer to the user "thing*"
> and a pointer to a "filled" variable to indicate whether a userspace
> buffer did get filled in (for fiemap, hole "extents" are skipped).
> 
> I'm just using the getbmapx struct as a "common denominator" because
> as far as I can see, it holds all info that any formatters will care
> about.
> 
> ("*thing" because fiemap doesn't pass the user pointer around, but rather
> has a pointer to a fiemap info structure, and helpers associated with it)
> 
> I'm still working on the fiemap hookup but wanted to put this out for comment.

This looks good to me.

>  /*
> - * Fcntl interface to xfs_bmapi.
> + * ioctl interface to xfs_bmapi.
>   */

>  /*
> - * Fcntl interface to xfs_bmapi.
> + * ioctl interface to xfs_bmapi.
>   */

Well, it will be for fiemap, too.  And the comment doesn't make much
sense either.  Either remove it completely or replace it by something
that makes sense.

<Prev in Thread] Current Thread [Next in Thread>