Christoph Hellwig wrote:
> Ping? This is just a trivial comment fixup, shouldn't be that hard to
> review..
This is to cleanup the comments from the xfs_rmd -> xfs_remove merge.
Ok then, its in.
>
> On Thu, Aug 07, 2008 at 11:58:49PM +0200, Christoph Hellwig wrote:
>> The dp to ip comment should be for the unconditional xfs_droplink
>> call, and the "." link obviously only exists for directories,
>> so it should be in the is_dir conditional.
>>
>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>>
>> Index: linux-2.6-xfs/fs/xfs/xfs_vnodeops.c
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/xfs_vnodeops.c 2008-08-06 17:26:37.000000000
>> -0300
>> +++ linux-2.6-xfs/fs/xfs/xfs_vnodeops.c 2008-08-06 17:36:44.000000000
>> -0300
>> @@ -2014,7 +2014,7 @@ xfs_remove(
>> goto out_bmap_cancel;
>>
>> /*
>> - * Drop the link from dp to ip.
>> + * Drop the "." link from ip to self.
>> */
>> error = xfs_droplink(tp, ip);
>> if (error)
>> @@ -2029,7 +2029,7 @@ xfs_remove(
>> }
>>
>> /*
>> - * Drop the "." link from ip to self.
>> + * Drop the link from dp to ip.
>> */
>> error = xfs_droplink(tp, ip);
>> if (error)
> ---end quoted text---
>
|