[Top] [All Lists]

Re: [PATCH 2/3] stop using xfs_itobp in xfs_iread

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 2/3] stop using xfs_itobp in xfs_iread
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 21 Oct 2008 13:55:36 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081020222040.GB23662@xxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
References: <20081020222040.GB23662@xxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Oct 21, 2008 at 12:20:40AM +0200, Christoph Hellwig wrote:
> The only caller of xfs_itobp that doesn't have i_blkno setup is now
> the initial inode read.  It needs access to the whole xfs_imap so using
> xfs_inotobp is not an option.  Instead opencode the buffer lookup in
> xfs_iread and kill all the functionality for the initial map from
> xfs_itobp.

Ok, looks good. Makes xfs_itobp() nice and simple now.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>