[Top] [All Lists]

Re: [PATCH 1/3] stop using xfs_itobp in xfs_bulkstat

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 1/3] stop using xfs_itobp in xfs_bulkstat
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 21 Oct 2008 13:44:55 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081020222036.GA23662@xxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
References: <20081020222036.GA23662@xxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Oct 21, 2008 at 12:20:36AM +0200, Christoph Hellwig wrote:
> xfs_bulkstat only wants the dinode, offset and buffer from a given
> inode number.  Instead of using xfs_itobp on a fake inode that is much
> easier done with xfs_inotobp, which just needs an imap_flag paramter to
> pass down the XFS_IMAP_BULKSTAT flag.

Nice - that removes the only external user of xfs_inode_alloc() very
cleanly. Looks ok to me.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>