xfs
[Top] [All Lists]

Re: XFS_ERROR use - was Re: [PATCH] prevent NULL returns from d_obtain_a

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: XFS_ERROR use - was Re: [PATCH] prevent NULL returns from d_obtain_alias
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 17 Oct 2008 19:10:00 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <48F7D814.2080705@xxxxxxx>
References: <20081015192839.GA867@xxxxxx> <E1KqWzC-00087u-TG@xxxxxxxxxxxxxxxxxxx> <20081016180947.GA26285@xxxxxx> <48F7D814.2080705@xxxxxxx>
User-agent: Mutt/1.3.28i
> 
> Fair enough.
> But XFS_ERROR is used throughout the function.

Can we leave it the simple way for now?  I have to revamp that whole
function anyway as it's extremly buggy in many ways, especially when
used to open directories (can lead to multiple dentries for a single
directory - ouch) and then I'll kill the other uses.

<Prev in Thread] Current Thread [Next in Thread>