xfs
[Top] [All Lists]

Re: [PATCH] XFS fix remount rw with unrecognized options

To: Jianjun Kong <jianjun@xxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, stable@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] XFS fix remount rw with unrecognized options
From: Timothy Shimmin <tes@xxxxxxx>
Date: Fri, 17 Oct 2008 09:48:07 +1100
In-reply-to: <20081016223637.GB31761@disturbed>
References: <20081016002926.D912558FA22B@xxxxxxxxxxxxxxxxxxxxxxx> <20081016134112.GA8773@ubuntu> <20081016223637.GB31761@disturbed>
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
Dave Chinner wrote:
> On Thu, Oct 16, 2008 at 09:41:12PM +0800, Jianjun Kong wrote:
>> And the code above "return 0" can not be executed, so delete them.
>> __________________________________________
>> #if 0
>>                         printk(KERN_INFO
>>         "XFS: mount option \"%s\" not supported for remount\n", p);
>>                         return -EINVAL;
>> #else                                                                        
>>                                     
>>                         return 0;
>> -----------------------------------------
> 
> That ifdef was added to stub out the behaviour we *actually want*
> remount to have when it encounters an invalid remount option.
> The reason for leaving it is in the next release we should have all
> the other problems we discovered by doing this fixed, so that
> code will be re-enabled. Hence the temporary #if 0 around it.
> 
> So at this point, don't remove it.
> 
> Cheers,
> 
> Dave.

Exactly.
I don't want it removed.
Extra code for comparing existing mount state with new mount state
needs to be done and this code can be reactivated when we sort
this stuff out later.
This patch should be just the fix for the current regression.

Thanks,
--Tim

<Prev in Thread] Current Thread [Next in Thread>