xfs
[Top] [All Lists]

Re: [PATCH] XFS fix remount rw with unrecognized options

To: Jianjun Kong <jianjun@xxxxxxxxx>
Subject: Re: [PATCH] XFS fix remount rw with unrecognized options
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 17 Oct 2008 09:36:37 +1100
Cc: Tim Shimmin <tes@xxxxxxx>, stable@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20081016134112.GA8773@ubuntu>
Mail-followup-to: Jianjun Kong <jianjun@xxxxxxxxx>, Tim Shimmin <tes@xxxxxxx>, stable@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
References: <20081016002926.D912558FA22B@xxxxxxxxxxxxxxxxxxxxxxx> <20081016134112.GA8773@ubuntu>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Oct 16, 2008 at 09:41:12PM +0800, Jianjun Kong wrote:
> 
> And the code above "return 0" can not be executed, so delete them.
> __________________________________________
> #if 0
>                         printk(KERN_INFO
>         "XFS: mount option \"%s\" not supported for remount\n", p);
>                         return -EINVAL;
> #else                                                                         
>                                    
>                         return 0;
> -----------------------------------------

That ifdef was added to stub out the behaviour we *actually want*
remount to have when it encounters an invalid remount option.
The reason for leaving it is in the next release we should have all
the other problems we discovered by doing this fixed, so that
code will be re-enabled. Hence the temporary #if 0 around it.

So at this point, don't remove it.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>