xfs
[Top] [All Lists]

TAKE 988145 - XFS: Check for valid transaction headers in recovery

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: TAKE 988145 - XFS: Check for valid transaction headers in recovery
From: tes@xxxxxxx (Tim Shimmin)
Date: Thu, 16 Oct 2008 17:13:34 +1100 (EST)
Check for valid transaction headers in recovery

When we are about to add a new item to a transaction in recovery, we
need to check that it is valid first. Currently we just assert that
header magic number matches, but in production systems that is not
present and we add a corrupted transaction to the list to be
processed. This results in a kernel oops later when processing the
corrupted transaction.

Instead, if we detect a corrupted transaction, abort recovery and
leave the user to clean up the mess that has occurred.

Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

Date:  Thu Oct 16 17:11:12 EST 2008
Workarea:  chook.melbourne.sgi.com:/build/tes/2.6.x-xfs-quilt
Inspected by:  david@xxxxxxxxxxxxx,sandeen@xxxxxxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:32356a
fs/xfs/xfs_log_recover.c - 1.355 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_log_recover.c.diff?r1=text&tr1=1.355&r2=text&tr2=1.354&f=h
        - check for valid trans headers in recovery


<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 988145 - XFS: Check for valid transaction headers in recovery, Tim Shimmin <=