xfs
[Top] [All Lists]

Re: [PATCH] remove exports of inline functions

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] remove exports of inline functions
From: Donald Douwsma <donaldd@xxxxxxx>
Date: Thu, 16 Oct 2008 11:19:03 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081015104840.GA8853@xxxxxx>
References: <20081006181626.GA15388@xxxxxx> <20081015104840.GA8853@xxxxxx>
User-agent: Thunderbird 2.0.0.17 (X11/20080925)
Christoph Hellwig wrote:
> On Mon, Oct 06, 2008 at 08:16:26PM +0200, Christoph Hellwig wrote:
>> Recent gcc starts to complain about exports of functions marked static
>> inline, so let's get rid of those.
> 
> note that the complain is in the form of a kernel doesn't link, so any
> chance we could get this patch in?

Yes, picking it up now.

>>
>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>>
>> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_ksyms.c  2008-10-07 
>> 01:08:33.000000000 +0000
>> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c       2008-10-07 
>> 01:09:58.000000000 +0000
>> @@ -153,8 +153,6 @@
>>  EXPORT_SYMBOL(kmem_zalloc);
>>  EXPORT_SYMBOL(kmem_zone_alloc);
>>  EXPORT_SYMBOL(kmem_zalloc_greedy);
>> -EXPORT_SYMBOL(kmem_zone_free);
>> -EXPORT_SYMBOL(kmem_zone_init);
>>  EXPORT_SYMBOL(kmem_zone_zalloc);
>>  EXPORT_SYMBOL(xfs_address_space_operations);
>>  EXPORT_SYMBOL(xfs_dir_file_operations);
>> @@ -217,8 +215,6 @@
>>  EXPORT_SYMBOL(xfs_finish_reclaim_all);
>>  EXPORT_SYMBOL(xfs_freesb);
>>  EXPORT_SYMBOL(xfs_fs_cmn_err);
>> -EXPORT_SYMBOL(xfs_highbit32);
>> -EXPORT_SYMBOL(xfs_highbit64);
>>  EXPORT_SYMBOL(xfs_idestroy);
>>  EXPORT_SYMBOL(xfs_iextract);
>>  EXPORT_SYMBOL(xfs_iext_add);
>> @@ -227,10 +223,7 @@
>>  EXPORT_SYMBOL(xfs_iext_idx_to_irec);
>>  EXPORT_SYMBOL(xfs_iext_insert);
>>  EXPORT_SYMBOL(xfs_iext_remove);
>> -EXPORT_SYMBOL(xfs_iflock);
>> -EXPORT_SYMBOL(xfs_iflock_nowait);
>>  EXPORT_SYMBOL(xfs_iflush);
>> -EXPORT_SYMBOL(xfs_ifunlock);
>>  EXPORT_SYMBOL(xfs_iget);
>>  EXPORT_SYMBOL(xfs_ilock);
>>  EXPORT_SYMBOL(xfs_ilock_map_shared);
> ---end quoted text---
> 

<Prev in Thread] Current Thread [Next in Thread>