xfs
[Top] [All Lists]

TAKE 988236 - fix remount rw with unrecognized options

To: xfs@xxxxxxxxxxx, sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 988236 - fix remount rw with unrecognized options
From: tes@xxxxxxx (Tim Shimmin)
Date: Wed, 15 Oct 2008 16:51:24 +1100 (EST)
fix remount rw with unrecognized options

When we skip unrecognized options in xfs_fs_remount we should just break
out of the switch and not return because otherwise we may skip clearing
the xfs-internal read-only flag.  This will only show up on some
operations like touch because most read-only checks are done by the VFS
which thinks this filesystem is r/w.  Eventually we should replace the
XFS read-only flag with a helper that always checks the VFS flag to make
sure they can never get out of sync.

Bug reported and fix verified by Marcel Beister on #xfs.
Bug fix verified by updated xfstests/189.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Date:  Wed Oct 15 16:50:37 EST 2008
Workarea:  chook.melbourne.sgi.com:/build/tes/2.6.x-xfs-quilt
Inspected by:  hch@xxxxxx,sandeen@xxxxxxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:32341a
fs/xfs/linux-2.6/xfs_super.c - 1.462 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.c.diff?r1=text&tr1=1.462&r2=text&tr2=1.461&f=h
        - fix remount rw with unrecognized options


<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 988236 - fix remount rw with unrecognized options, Tim Shimmin <=