xfs
[Top] [All Lists]

TAKE 988141 - Never call mark_inode_dirty_sync() directly

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: TAKE 988141 - Never call mark_inode_dirty_sync() directly
From: lachlan@xxxxxxx (Lachlan McIlroy)
Date: Tue, 14 Oct 2008 15:50:38 +1100 (EST)
Never call mark_inode_dirty_sync() directly

Once the Linux inode and the XFS inode are combined, we cannot rely
on just check if the linux inode exists as a method of determining
if it is valid or not. Hence we should always call
xfs_mark_inode_dirty_sync() instead as it does the correct checks to
determine if the liinux inode is in a valid state or not.

Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

Date:  Tue Oct 14 15:50:14 EST 2008
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-inode
Inspected by:  hch
Author:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:32318a
fs/xfs/linux-2.6/xfs_super.c - 1.457 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.c.diff?r1=text&tr1=1.457&r2=text&tr2=1.456&f=h
fs/xfs/linux-2.6/xfs_iops.c - 1.301 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_iops.c.diff?r1=text&tr1=1.301&r2=text&tr2=1.300&f=h
fs/xfs/linux-2.6/xfs_aops.c - 1.166 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_aops.c.diff?r1=text&tr1=1.166&r2=text&tr2=1.165&f=h
        - Never call mark_inode_dirty_sync() directly



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 988141 - Never call mark_inode_dirty_sync() directly, Lachlan McIlroy <=