[Top] [All Lists]

Re: fw: [PATCH] fix instant oops with tracing enabled

To: Mark Goodwin <markgw@xxxxxxx>
Subject: Re: fw: [PATCH] fix instant oops with tracing enabled
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 14 Oct 2008 13:04:57 +1100
Cc: xfs@xxxxxxxxxxx, hch@xxxxxx
In-reply-to: <48F3EA6F.9000209@xxxxxxx>
Mail-followup-to: Mark Goodwin <markgw@xxxxxxx>, xfs@xxxxxxxxxxx, hch@xxxxxx
References: <20081013223932.GE10716@disturbed> <48F3EA6F.9000209@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Oct 14, 2008 at 10:40:15AM +1000, Mark Goodwin wrote:
> Dave Chinner wrote:
>> SGI folks,
>> Looks like Christoph is having problems posting to the list;
>> the spam filter is dropping all his mail. In the mean time,
>> here's a fix for an oops in the tracing code as a result of
>> the last check ins. I didn't see this because the "combine
>> inodes" patches removes xfs_icount altogether.
> Lachlan also saw some regressions after merging these patchsets :
> . replace the mount inode list with radix tree traversals
> . clean up sync code

Can you share with us all what those problems are? I can't help
find and fix the problems if I don't get told about them. perhaps
you should be opening bugzilla bugs rather than internal bugworks
PVs for regressions as a result of merges of community patch

>> If that
>> series is going to be included in the current round of checkins
>> then this patch probably isn't needed.
> The agreed plan for 2.6.28 still has the following patchsets to go in:
> . Combine the XFS and Linux inode structures V2
> . Track reclaimable inodes in inode cache
> . AIL cleanup and bug fixes
> . Account for allocated blocks when expanding directories
> . Check for valid transaction headers in recovery
> . fix remount rw with unrecognized options
> It's starting to look like a pretty aggressive merge and QA schedule.

We've got all of the -rc series to address regressions.

> Dave, is it worth doing any testing until these are *all* merged?

IMO, no, but that's up to you guys. I'd just merge them, run some
basic QA then push them to linus.  We've still got the whole -rc
series to address regressions.  And if you tell us about
regressions, we can help track them down and get them fixed quickly.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>