[Top] [All Lists]

TAKE 988140 - Kill SYNC_CLOSE

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: TAKE 988140 - Kill SYNC_CLOSE
From: lachlan@xxxxxxx (Lachlan McIlroy)
Date: Mon, 13 Oct 2008 17:41:34 +1100 (EST)

SYNC_CLOSE is only ever used and checked in conjunction with
SYNC_WAIT, and this only done in one spot. The only thing
this does is make XFS_bflush() calls to the data buftargs.

This will happen very shortly afterwards the xfs_sync() call
anyway in the unmount path via the xfs_close_devices(), so this
code is redundant and can be removed. That only user of SYNC_CLOSE
is now gone, so kill the flag completely.

Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

Date:  Mon Oct 13 17:41:16 EST 2008
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-sync
Inspected by:  hch
Author:  lachlan

The following file(s) were checked into:

Modid:  xfs-linux-melb:xfs-kern:32310a
fs/xfs/linux-2.6/xfs_super.c - 1.455 - changed
fs/xfs/linux-2.6/xfs_sync.h - 1.6 - changed
fs/xfs/linux-2.6/xfs_sync.c - 1.15 - changed
        - Kill SYNC_CLOSE

<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 988140 - Kill SYNC_CLOSE, Lachlan McIlroy <=