[Top] [All Lists]

Re: [PATCH] fix remount rw with unrecognized options

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] fix remount rw with unrecognized options
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 12 Oct 2008 17:21:44 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081012222032.GA19748@xxxxxx>
References: <20081012123044.GA30272@xxxxxx> <48F27807.1080702@xxxxxxxxxxx> <20081012222032.GA19748@xxxxxx>
User-agent: Thunderbird (Macintosh/20080914)
Christoph Hellwig wrote:
> On Sun, Oct 12, 2008 at 05:19:51PM -0500, Eric Sandeen wrote:
>> Christoph Hellwig wrote:
>>> When we skip unrecognized options in xfs_fs_remount we should just break
>>> out of the switch and not return because otherwise we may skip clearing
>>> the xfs-internal read-only flag.  This will only show up on some
>>> operations like touch because most read-only checks are done by the VFS
>>> which things this filesystem is r/w.  Eventually we should replace the
>>> XFS read-only flag with a helper that always checks the VFS flag to make
>>> sure they can never get out of sync.
>>> Bug reported and fix verified by Marcel Beister on #xfs.
>> Seems reasonable.
>> I think this is material?
> Yes.

The recent bug on oss.sgi.com is probably the same; I'm updating it now.


<Prev in Thread] Current Thread [Next in Thread>