xfs
[Top] [All Lists]

Re: [PATCH] fix remount rw with unrecognized options

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] fix remount rw with unrecognized options
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 12 Oct 2008 17:19:51 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081012123044.GA30272@xxxxxx>
References: <20081012123044.GA30272@xxxxxx>
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
Christoph Hellwig wrote:
> When we skip unrecognized options in xfs_fs_remount we should just break
> out of the switch and not return because otherwise we may skip clearing
> the xfs-internal read-only flag.  This will only show up on some
> operations like touch because most read-only checks are done by the VFS
> which things this filesystem is r/w.  Eventually we should replace the
> XFS read-only flag with a helper that always checks the VFS flag to make
> sure they can never get out of sync.
> 
> Bug reported and fix verified by Marcel Beister on #xfs.

Seems reasonable.

I think this is 2.6.27.1 material?

-Eric

> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_super.c   2008-10-11 
> 00:59:04.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c        2008-10-11 
> 00:59:35.000000000 +0200
> @@ -1218,7 +1218,7 @@ xfs_fs_remount(
>       "XFS: mount option \"%s\" not supported for remount\n", p);
>                       return -EINVAL;
>  #else
> -                     return 0;
> +                     break;
>  #endif
>               }
>       }
> 
> 

<Prev in Thread] Current Thread [Next in Thread>