Re: [PATCH 2/3] kill xfs_ialloc_log_di

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Tue, Oct 07, 2008 at 10:21:57PM +0200, Christoph Hellwig wrote:
> xfs_ialloc_log_di alwasy logs the full inode core + di_next_unlinked, so
> there's really no need for all the offset magic and we can just call
> xfs_trans_log_buf directly from it's only user.  Also add a comment
> describing what we should do here instead.

Looks like a good idea. I'll have to redo some patches on top of
this, but otherwise I think it's fine.

> @@ -406,18 +344,25 @@ xfs_ialloc_ag_alloc(
>                                        XFS_BUF_LOCK);
>               ASSERT(fbuf);
>               ASSERT(!XFS_BUF_GETERROR(fbuf));
> +
>               /*
> -              * Set initial values for the inodes in this buffer.
> +              * Initialize all inodes in this buffer and then log them.
> +              *
> +              * XXX: It would be much better if we had just one transaction 
> to
> +              *      log a whole cluster of inodes instead of all the 
> indivdual
> +              *      transactions causing a lot of log traffic.
>                */

That's the patch series I'll need to redo on top of this. ;)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx