Re: [PATCH 1/2, RFC] convert xfs_getbmap to take formatter functions

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Christoph Hellwig wrote:
> On Mon, Oct 20, 2008 at 05:24:03PM -0500, Eric Sandeen wrote:
...

>>  /*
>> - * Fcntl interface to xfs_bmapi.
>> + * ioctl interface to xfs_bmapi.
>>   */
> 
>>  /*
>> - * Fcntl interface to xfs_bmapi.
>> + * ioctl interface to xfs_bmapi.
>>   */
> 
> Well, it will be for fiemap, too.  And the comment doesn't make much
> sense either.  Either remove it completely or replace it by something
> that makes sense.
> 

well aren't XFS_IOC_GETBMAP(X) and fiemap _both_ ioctl interfaces to
xfs_bmapi?

-Eric