Re: XFS_ERROR use - was Re: [PATCH] prevent NULL returns from d_obtain_alias

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Mon, Oct 20, 2008 at 11:49:47AM +1100, Timothy Shimmin wrote:
> > I have to revamp that whole
> > function anyway as it's extremly buggy in many ways, especially when
> > used to open directories (can lead to multiple dentries for a single
> > directory - ouch) and then I'll kill the other uses.
> 
> Oh ok.
> 
> In userspace,
> we use it for opening directories on xfsdump via jdm_open in order to
> do bulkstat driven dirent dumping.
> We also use it in xfsrestore - though I am not convinced we should -
> it was initially done for "performance" reasons apparently.

I think the use of the API is fine, the problem is that the current
implemention is buggy.