|To:||Dave Chinner <david@xxxxxxxxxxxxx>|
|Subject:||Re: [PATCH] XFS: don't block in xfs_qm_dqflush() during async writeback|
|From:||Peter Leckie <pleckie@xxxxxxx>|
|Date:||Fri, 10 Oct 2008 11:16:06 +1000|
|User-agent:||Thunderbird 18.104.22.168 (X11/20080707)|
Dave Chinner wrote:
Normally dquots are written back via delayed write mechanisms. They are flushed to their backing buffer by xfssyncd, which is then pushed out by either AIL or xfsbufd flushing. The flush from the xfssyncd is supposed to be non-blocking, but xfs_qm_dqflush() always waits for pinned duots, which means that it will block for the length of time it takes to do a synchronous log force. This causes unnecessary extra log I/O to be issued whenever we try to flush a busy dquot.
This patch looks good.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH V2] Re-dirty pages on ENOSPC when converting delayed allocations, Dave Chinner|
|Next by Date:||Re: [PATCH] fix barrier fail detection, Christoph Hellwig|
|Previous by Thread:||[PATCH] XFS: don't block in xfs_qm_dqflush() during async writeback, Dave Chinner|
|Next by Thread:||[PATCH] XFS: Account for allocated blocks when expanding directories, Dave Chinner|
|Indexes:||[Date] [Thread] [Top] [All Lists]|