xfs
[Top] [All Lists]

Re: REVIEW: Don't reset dirty inode flag in xfs_repair

To: Barry Naujok <bnaujok@xxxxxxx>
Subject: Re: REVIEW: Don't reset dirty inode flag in xfs_repair
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 29 Sep 2008 10:23:18 -0400
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
In-reply-to: <op.uhy9dlyz3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <op.uhy9dlyz3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Sep 24, 2008 at 06:47:35PM +1000, Barry Naujok wrote:
> If an inode is dirtied due to some error in an inode, the very last
> check (nlink version) in process_dinode_int() in xfs_repair sets the
> dirty flag rather than just bumping it if it dirtied the inode.
>
> So, if something earlier dirtied the inode without marking it bad
> (eg. resetting the inode's next unlinked field in the example that
> detected this issue), that dirty state will be lost if the nlink
> version checks out fine.

Looks good, but the diff you posted also includes a hunk in db/check.c
that introduces another sanity check in process_inode() which seems
unrelated.

<Prev in Thread] Current Thread [Next in Thread>