xfs
[Top] [All Lists]

Re: [PATCH 3/3] Add timeout feature

To: "Ric Wheeler" <rwheeler@xxxxxxxxxx>, "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] Add timeout feature
From: "Takashi Sato" <t-sato@xxxxxxxxxxxxx>
Date: Mon, 29 Sep 2008 20:11:41 +0900
Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "Oleg Nesterov" <oleg@xxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>, <dm-devel@xxxxxxxxxx>, <viro@xxxxxxxxxxxxxxxxxx>, <linux-ext4@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, <axboe@xxxxxxxxx>, <mtk.manpages@xxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <48DCC043.1020207@xxxxxxxxxx>
References: <20080908205337t-sato@xxxxxxxxxxxxxxx> <20080908171119.GB22521@xxxxxxxxxxxxx> <48DBFD42.6030307@xxxxxxxxxx> <D0B0D91F884647D6808626CDFF81E532@xxxxxxxxxxxxxxxx> <48DCC043.1020207@xxxxxxxxxx>
Hi Ric and Christoph,

Ric Wheeler wrote:
And as with all previous posting I still fundamentally disagree about
the need of this functionality.  We don't need a timeout for freezing.

I agree with Christoph here, I think that the timeout is unneeded.

I think that your concern is that the freezer cannot recognize the occurrence
of a timeout and it continues the backup process and the backup data is
corrupted finally.
If the freezer can recognize it by the unfreeze ioctl's errono, will your 
concern
be solved?
If so, I will implement it.

Cheers, Takashi

I think that is certainly part a big part of my concern.

Also note that the timeout seems to be quite low relative to say the standard timeout for a SCSI device (30 seconds worst case).

In general, I am quite supportive of the patch series and think that this is a 
great addition.

Thank you for your comments.
Christoph, do you have any comments about this solution?

If it's OK, I will change the freeze patch so that the unfreeze ioctl sets
ETIMEDOUT to errno when the timeout occurs.

Cheers, Takashi

<Prev in Thread] Current Thread [Next in Thread>