xfs
[Top] [All Lists]

compiler warning after applying btree patches

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: compiler warning after applying btree patches
From: Lachlan McIlroy <lachlan@xxxxxxx>
Date: Mon, 29 Sep 2008 17:33:41 +1000
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Reply-to: lachlan@xxxxxxx
User-agent: Thunderbird 2.0.0.17 (X11/20080914)
Christoph,

After applying the first round of btree patches we've now got this warning
when building a non-debug xfs module.

 CC      fs/xfs/xfs_btree.o
fs/xfs/xfs_btree.c:191: warning: ‘xfs_btree_check_ptr’ defined but not used

I took a quick look through your next round of btree patches but couldn't
see a fix for it.  Did I miss something in the original patch set?  Is it
fixed in a later patch?  If not here's a fix:

--- a/fs/xfs/xfs_btree.c        2008-09-29 17:19:24.000000000 +1000
+++ b/fs/xfs/xfs_btree.c        2008-09-29 17:22:33.000000000 +1000
@@ -160,6 +160,7 @@ xfs_btree_check_lptr(
        return 0;
}

+#ifdef DEBUG
/*
 * Check that (short) pointer is ok.
 */
@@ -197,6 +198,7 @@ xfs_btree_check_ptr(
                                be32_to_cpu((&ptr->s)[index]), level);
        }
}
+#endif

/*
 * Delete the btree cursor.

<Prev in Thread] Current Thread [Next in Thread>