xfs
[Top] [All Lists]

Re: [PATCH] Clean up dquot pincount code

To: Peter Leckie <pleckie@xxxxxxx>
Subject: Re: [PATCH] Clean up dquot pincount code
From: Donald Douwsma <donaldd@xxxxxxx>
Date: Mon, 29 Sep 2008 12:11:29 +1000
Cc: xfs@xxxxxxxxxxx, xfs-dev <xfs-dev@xxxxxxx>
In-reply-to: <48E02E3D.3000104@xxxxxxx>
References: <48DC6102.2040602@xxxxxxx> <48E02E3D.3000104@xxxxxxx>
User-agent: Thunderbird 2.0.0.17 (X11/20080925)
Peter Leckie wrote:
> This is a fix for patch " Clean up dquot pincount code"
> which introduced a build breakage due to a missing & in
> xfs_qm_dquot_logitem_pin.
> 
> 
> Signed-off-by: Peter Leckie <pleckie@xxxxxxx>
> 
> Index: 2.6.x-xfs/fs/xfs/quota/xfs_dquot_item.c
> ===================================================================
> --- 2.6.x-xfs.orig/fs/xfs/quota/xfs_dquot_item.c
> +++ 2.6.x-xfs/fs/xfs/quota/xfs_dquot_item.c
> @@ -96,7 +96,7 @@ xfs_qm_dquot_logitem_pin(
>        xfs_dquot_t *dqp = logitem->qli_dquot;
> 
>        ASSERT(XFS_DQ_IS_LOCKED(dqp));
> -       atomic_inc(dqp->q_pincount);
> +       atomic_inc(&dqp->q_pincount);
> }
> 
> /*

Looks good Peter,

seems we all missed this in review :(

Don


<Prev in Thread] Current Thread [Next in Thread>