Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Fri, Sep 26, 2008 at 11:38:27AM +1000, Peter Leckie wrote:
> Lachlan McIlroy wrote:
>> The underlying problem has nothing to do with xfs_qm_dqflush() - the
>> spurious wakeups are caused by calls to wake_up_process() that  
>> arbitrarily
>> wake up a process that is in a state where it shouldn't be woken up.  If
>> we don't fix the spurious wakeups then we could easily re-introduce this
>> problem again.  If xfs_qm_dqflush() should be non-blocking then that's a
>> separate change and it sounds like a good change too.
> Ok so what do we want to do. It almost sounds like there are 3 issues I  
> need to solve,
> first clean up the code, second make xfs_qm_dqflush() non blocking, and 3ed
> fix up the spurious wakeups.
>
> Should I propose 3 patches to fix each of these issues?

Well, your patch for 1 is in, Dave has one for 2, and I don't think
three is an issue - at least for xfssyncd.