| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 26 Sep 2008 07:28:33 -0400 |
| Cc: | Peter Leckie <pleckie@xxxxxxx>, xfs@xxxxxxxxxxx, xfs-dev@xxxxxxx |
| In-reply-to: | <48DC3682.2030602@xxxxxxx> |
| References: | <48D9C1DD.6030607@xxxxxxx> <48D9EB8F.1070104@xxxxxxx> <48D9EF6E.8010505@xxxxxxx> <20080924074604.GK5448@disturbed> <48D9F718.4010905@xxxxxxx> <20080925010318.GB27997@disturbed> <48DB4F3F.8040307@xxxxxxx> <48DC3682.2030602@xxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Fri, Sep 26, 2008 at 11:10:26AM +1000, Lachlan McIlroy wrote: > Good work Pete. We should also consider replacing all calls to > wake_up_process() with wake_up() and a wait queue so we don't go > waking up threads when we shouldn't be. No. The daemons should not block anyway in these places, and using a waitqueue just causes additional locking overhead. |
| Previous by Date: | Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount, Lachlan McIlroy |
| Next by Thread: | Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount, Lachlan McIlroy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |