| To: | Peter Leckie <pleckie@xxxxxxx>, xfs@xxxxxxxxxxx, xfs-dev@xxxxxxx |
|---|---|
| Subject: | Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 26 Sep 2008 07:27:29 -0400 |
| In-reply-to: | <20080926003401.GG27997@disturbed> |
| References: | <48D9C1DD.6030607@xxxxxxx> <48D9EB8F.1070104@xxxxxxx> <48D9EF6E.8010505@xxxxxxx> <20080924074604.GK5448@disturbed> <48D9F718.4010905@xxxxxxx> <20080925010318.GB27997@disturbed> <48DB4F3F.8040307@xxxxxxx> <20080926003401.GG27997@disturbed> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
> /*
> - * Cant flush a pinned dquot. Wait for it.
> + * Cant flush a pinned dquot. If we are not supposed to block,
> + * don't wait for it.
> */
> + if (!(flags & XFS_QMOPT_SYNC) && dqp->q_pincount > 0) {
> + xfs_dqfunlock(dqp);
> + return (0);
> + }
> xfs_qm_dqunpin_wait(dqp);
Looks good, but please remove the braces around the 0. (And yes, I know
that the statement just above it does it too..)
|
| Previous by Date: | Re: [PATCH 0/9] CRC support for superblock, ag headers, log and btree blocks, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount, Christoph Hellwig |
| Next by Thread: | Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |