[Top] [All Lists]

Re: [PATCH] Clean up dquot pincount code

To: Peter Leckie <pleckie@xxxxxxx>
Subject: Re: [PATCH] Clean up dquot pincount code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 26 Sep 2008 02:31:32 -0400
Cc: xfs@xxxxxxxxxxx, xfs-dev <xfs-dev@xxxxxxx>
In-reply-to: <48DC6102.2040602@xxxxxxx>
References: <48DC6102.2040602@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Sep 26, 2008 at 02:11:46PM +1000, Peter Leckie wrote:
> This is a code cleanup and optimization that removes a per mount point
> spinlock from the quota code and cleans up the code.
> The patch changes the pincount from being an int protected by a spinlock
> to an atomic_t allowing the pincount to be manipulated without holding
> the spinlock.
> This cleanup also protects against random wakup's of both the aild and
> xfssyncd by reevaluating the pincount after been woken. Two latter patches
> will address the Spurious wakeups.

Looks good.

<Prev in Thread] Current Thread [Next in Thread>