xfs
[Top] [All Lists]

Re: [PATCH] Clean up dquot pincount code

To: Peter Leckie <pleckie@xxxxxxx>
Subject: Re: [PATCH] Clean up dquot pincount code
From: Donald Douwsma <donaldd@xxxxxxx>
Date: Fri, 26 Sep 2008 14:30:45 +1000
Cc: xfs@xxxxxxxxxxx, xfs-dev <xfs-dev@xxxxxxx>
In-reply-to: <48DC6102.2040602@xxxxxxx>
References: <48DC6102.2040602@xxxxxxx>
User-agent: Thunderbird 2.0.0.16 (X11/20080724)
Peter Leckie wrote:
> This is a code cleanup and optimization that removes a per mount point
> spinlock from the quota code and cleans up the code.
> 
> The patch changes the pincount from being an int protected by a spinlock
> to an atomic_t allowing the pincount to be manipulated without holding
> the spinlock.
> 
> This cleanup also protects against random wakup's of both the aild and
> xfssyncd by reevaluating the pincount after been woken. Two latter patches
> will address the Spurious wakeups.
> 
> Signed-off-by: Peter Leckie <pleckie@xxxxxxx>

Looks good Peter, nice to get rid of that spinlock.

Don

<Prev in Thread] Current Thread [Next in Thread>