| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, Takashi Sato <t-sato@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/3] Add timeout feature |
| From: | Ric Wheeler <rwheeler@xxxxxxxxxx> |
| Date: | Thu, 25 Sep 2008 17:06:10 -0400 |
| Cc: | Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "viro@xxxxxxxxxxxxxxxxxx" <viro@xxxxxxxxxxxxxxxxxx>, "linux-ext4@xxxxxxxxxxxxxxx" <linux-ext4@xxxxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, "axboe@xxxxxxxxx" <axboe@xxxxxxxxx>, "mtk.manpages@xxxxxxxxxxxxxx" <mtk.manpages@xxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx> |
| In-reply-to: | <20080908171119.GB22521@xxxxxxxxxxxxx> |
| References: | <20080908205337t-sato@xxxxxxxxxxxxxxx> <20080908171119.GB22521@xxxxxxxxxxxxx> |
| User-agent: | Thunderbird 2.0.0.16 (X11/20080723) |
Christoph Hellwig wrote: On Mon, Sep 08, 2008 at 08:53:37PM +0900, Takashi Sato wrote:The timeout feature is added to "freeze ioctl" to solve a deadlock when the freezer accesses a frozen filesystem. And new ioctl to reset the timeout period is added to extend the timeout period. For example, the freezer resets the timeout period to 10 seconds every 5 seconds. In this approach, even if the freezer causes a deadlock by accessing the frozen filesystem, it will be solved by the timeout in 10 seconds and the freezer will be able to recognize that at the next reset of timeout period.And as with all previous posting I still fundamentally disagree about the need of this functionality. We don't need a timeout for freezing. I agree with Christoph here, I think that the timeout is unneeded. Regards, Ric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.6.27-rc7 no init found on the root partition?, Lukas Hejtmanek |
|---|---|
| Next by Date: | Re: [PATCH 4/10] xfs: Fix error handling in write_super_lockfs/unlockfs, Eric Sandeen |
| Previous by Thread: | Re: [PATCH 3/3] Add timeout feature, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 3/3] Add timeout feature, Takashi Sato |
| Indexes: | [Date] [Thread] [Top] [All Lists] |